anirudhacharya edited a comment on issue #13083: [MXNET-345] Hardmax operator URL: https://github.com/apache/incubator-mxnet/pull/13083#issuecomment-445442255 It looks good to me for the scope defined. But the following two questions remain - - Why put it in contrib? - Should we wait for a full implementation of this operator rather than have this frontend implementation? Raising these points so that the person merging the PR will consider them while merging it. Otherwise it LGTM.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
