lebeg commented on a change in pull request #13576: [MXNET-679] Improved CMakeLists.txt URL: https://github.com/apache/incubator-mxnet/pull/13576#discussion_r240026721
########## File path: cmake/cmake_options.yml ########## @@ -26,7 +26,7 @@ USE_SSE: "ON" # Build with x86 SSE instruction support IF NOT ARM USE_F16C: "ON" # Build with x86 F16C instruction support) # autodetects support if "ON" USE_LAPACK: "ON" # Build with lapack support USE_MKL_IF_AVAILABLE: "ON" # Use MKL if found -USE_MKLML_MKL: "ON" # Use MKLDNN variant of MKL (if MKL found) IF USE_MKL_IF_AVAILABLE AND (NOT APPLE) +USE_MKLML: "ON" # Use MKLDNN variant of MKL (if MKL found) IF USE_MKL_IF_AVAILABLE AND (NOT APPLE) Review comment: > You are right that we do not guarantee compatibility, but I don't see a good reason here why we should break it intentionally. Could you elaborate? Because the name does not make sense and leads to confusion. > The comment states that this option is to specifically use the mkldnn variant of mkl and not the standalone mkldnn. This is an example of the confusion. There is no such thing as *mkldnn variant of mkl*. There is MKLDNN - an independent addition to MKL. And there is a packed (and easier to download) version of MKL - MKLML. What is and was wrong though is the comment about this variable, since the option is not related to MKLDNN. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
