ciyongch commented on issue #13596: Fix quantize pass error when excluding a 
quantization supported op
URL: https://github.com/apache/incubator-mxnet/pull/13596#issuecomment-445700393
 
 
   @pengzhao-intel The picture of graph might not reflect the error, an 
enhanced test was added to cover this kind of cases. I paste the full symbol 
file of the test case w/ and w/o the fix.
   - symbol file **w/o** fix 
[exclude_pool0.txt](https://github.com/apache/incubator-mxnet/files/2661750/exclude_pool0.txt)
   - symbol file **w/** fix 
[exclude_pool0_fix.txt](https://github.com/apache/incubator-mxnet/files/2661751/exclude_pool0_fix.txt)
   
   The incorrect connection (error entry index) is located at 3nd/4th input 
(counting from 0), **[21, 4294967295, 0], [21, 0, 0]**
   ```
       {
         "op": "_contrib_quantized_conv", 
         "name": "quantized_conv1", 
         "attrs": {
           "kernel": "(1, 1)", 
           "no_bias": "False", 
           "num_filter": "4", 
           "pad": "(0, 0)"
         }, 
         "inputs": [[21, 0, 0], [22, 0, 0], [23, 0, 0], [21, 4294967295, 0], 
[21, 0, 0], [24, 0, 0], [25, 0, 0], [26, 0, 0], [27, 0, 0]]
       },
   ```
   After fixed, the connection is as below, 3nd/4th inputs are correct now 
**[21, 1, 0], [21, 2, 0]**
   ```
       {
         "op": "_contrib_quantized_conv", 
         "name": "quantized_conv1", 
         "attrs": {
           "kernel": "(1, 1)", 
           "no_bias": "False", 
           "num_filter": "4", 
           "pad": "(0, 0)"
         }, 
         "inputs": [[21, 0, 0], [22, 0, 0], [23, 0, 0], [21, 1, 0], [21, 2, 0], 
[24, 0, 0], [25, 0, 0], [26, 0, 0], [27, 0, 0]]
       }, 
       {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to