KellenSunderland commented on a change in pull request #12922: Support 
Quantized Fully Connected by INT8 GEMM
URL: https://github.com/apache/incubator-mxnet/pull/12922#discussion_r240126744
 
 

 ##########
 File path: tests/python/quantization/test_quantization.py
 ##########
 @@ -270,7 +270,7 @@ def check_quantized_pooling(data_shape, kernel, pool_type, 
pad, stride, global_p
 def test_quantized_fc():
     def check_quantized_fc(data_shape, num_hidden, no_bias, qdtype, 
flatten=True):
         if mx.current_context().device_type != 'gpu':
 
 Review comment:
   @pengzhao-intel Oh sorry, didn't realize that was the case.   If the tests 
won't pass without full mkl installed and it's not there let's add this in a 
later PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to