ptrendx commented on a change in pull request #13471: Optimization of metric
evaluation
URL: https://github.com/apache/incubator-mxnet/pull/13471#discussion_r240340275
##########
File path: python/mxnet/metric.py
##########
@@ -423,8 +501,11 @@ def update(self, labels, preds):
check_label_shapes(label, pred_label)
- self.sum_metric += (pred_label == label).sum()
+ num_correct = (pred_label == label).sum()
+ self.sum_metric += num_correct
+ self.global_sum_metric += num_correct
Review comment:
That said, this comment made me think about this again and I found a bug in
how I handle global statistics in `F1` and `MCC` metrics - fix and tests
incoming. Thank you!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
