yuxihu commented on a change in pull request #13602: Fix for import mxnet
taking long time if multiple process launched
URL: https://github.com/apache/incubator-mxnet/pull/13602#discussion_r240433178
##########
File path: src/operator/operator_tune-inl.h
##########
@@ -356,7 +356,8 @@ class OperatorTune : public OperatorTuneByType<DType> {
static duration_t GetOMPLoopOverhead() {
// It was found empirically that OMP times was not heavily tied to number
of cores,
// so take an average across all core counts
- const auto max_cores = static_cast<size_t>(omp_get_num_procs()) >> 1;
+ const auto max_cores_default = static_cast<size_t>(omp_get_num_procs()) >>
1;
+ const auto max_cores = dmlc::GetEnv("MXNET_USE_NUM_CORES_OPERATOR_TUNING",
max_cores_default);
Review comment:
Shall we document this newly added env variable somewhere? Otherwise users
may not know about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
