anirudh2290 commented on a change in pull request #12980: Add reshape op
supported by MKL-DNN
URL: https://github.com/apache/incubator-mxnet/pull/12980#discussion_r240435688
##########
File path: src/operator/tensor/matrix_op.cc
##########
@@ -171,9 +222,19 @@ If the argument `reverse` is set to 1, then the special
values are inferred from
.set_num_outputs(1)
.set_attr_parser(ParamParser<ReshapeParam>)
.set_attr<nnvm::FInferShape>("FInferShape", ReshapeShape)
+#if MXNET_USE_MKLDNN == 1
+.set_attr<FInferStorageType>("FInferStorageType", ReshapeStorageType)
+#endif
.set_attr<nnvm::FInferType>("FInferType", ElemwiseType<1, 1>)
.set_attr<nnvm::FGradient>("FGradient", ElemwiseGradUseNone{"_backward_copy"})
.set_attr<FCompute>("FCompute<cpu>", UnaryOp::IdentityCompute<cpu>)
+#if MXNET_USE_MKLDNN == 1
Review comment:
I know that this is not the first op which is implemented this way, but is
there a reason for the two different if blocks here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
