wkcn edited a comment on issue #11064: Flaky test: test_operator.test_op_roi_align URL: https://github.com/apache/incubator-mxnet/issues/11064#issuecomment-446055482 When MXNET_TEST_SEED=35650200, the error shows that: ``` in test_roi_align_value, assert_almost_equal(output.asnumpy(), real_output) AssertionError: Items are not equal: Error 3.147267 exceeds tolerance rtol=0.000010, atol=0.000000. Location of maximum error:(6, 0, 0, 1), a=0.005887, b=0.005887 a: array([[[[ 172.60527039, 173.5171814 , 174.42907715, 175.34100342], [ 195.92706299, 196.83895874, 197.75085449, 198.6627655 ], [ 219.24882507, 220.16073608, 221.07263184, 221.98455811]],... b: array([[[[ 172.60527627, 173.51718251, 174.42908875, 175.34099499], [ 195.9270587 , 196.83896494, 197.75087118, 198.66277742], [ 219.24884113, 220.16074737, 221.07265361, 221.98455985]],... ``` It's strange. ``` In this unittest, the `real_output` is computed in `float64`, so there is some float precision problem. I have fixed it, however the problem still exists. Error 4.049840 exceeds tolerance rtol=0.000010, atol=0.000000. Location of maximum error:(6, 0, 0, 1), a=0.005887, b=0.005887 a: array([[[[ 172.60527039, 173.5171814 , 174.42907715, 175.34100342], [ 195.92706299, 196.83895874, 197.75085449, 198.6627655 ], [ 219.24882507, 220.16073608, 221.07263184, 221.98455811]],... b: array([[[[ 172.60527039, 173.5171814 , 174.42907715, 175.34100342], [ 195.92706299, 196.83895874, 197.75085449, 198.6627655 ], [ 219.24884033, 220.16075134, 221.07266235, 221.98455811]],... ``` I think `atol` should be not 0.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
