marcoabreu commented on a change in pull request #13529: Improve dev_menu 
usability, local build and virtualenv
URL: https://github.com/apache/incubator-mxnet/pull/13529#discussion_r240689061
 
 

 ##########
 File path: ci/requirements_mxnet_virtualenv.txt
 ##########
 @@ -0,0 +1,6 @@
+opencv-python
 
 Review comment:
   We don't use that linked requirements.txt in our CI. Instead, we install 
OpenCV and all that as part of our docker setup. 
   
   If it would introduce errors, we would see it as part of the PR validation. 
Please, add your requirements to the linked requirements file and delete the 
one you created since they are redundant. The linked file is exactly for the 
purpose of providing an environment to run tests, which is also the purpose of 
your new requirements file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to