larroy commented on a change in pull request #13529: Improve dev_menu usability, local build and virtualenv URL: https://github.com/apache/incubator-mxnet/pull/13529#discussion_r240692530
########## File path: ci/requirements_mxnet_virtualenv.txt ########## @@ -0,0 +1,6 @@ +opencv-python Review comment: This is going to have implications on other places, in qemu we are installing those with: 81: check_call(['sudo', 'pip3', 'install', '-r', 'mxnet/tests/requirements.txt']) Any additional requirement can take a lot of time to compile in QEMU, I don't want to add requirements to the test files that are not needed. I'm against the change that you propose because this reason. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
