zheng-da commented on a change in pull request #13419: [MXNET-1233] Enable
dynamic shape in CachedOp
URL: https://github.com/apache/incubator-mxnet/pull/13419#discussion_r240889937
##########
File path: src/imperative/cached_op.cc
##########
@@ -834,6 +861,61 @@ OpStatePtr CachedOp::DynamicForward(
return op_state;
}
+OpStatePtr CachedOp::NaiveForward(
+ const Context& default_ctx,
+ const std::vector<NDArray*>& inputs,
+ const std::vector<NDArray*>& outputs) {
+ using namespace nnvm;
+ using namespace imperative;
+ // Initialize
+ bool recording = Imperative::Get()->is_recording();
+ auto op_state = OpStatePtr::Create<DynamicRuntime>();
+ auto& runtime = op_state.get_state<DynamicRuntime>();
+ {
+ auto state_ptr = GetCachedOpState(default_ctx);
+ auto& state = state_ptr.get_state<CachedOpState>();
+ std::lock_guard<std::mutex> lock(state.mutex);
+ SetForwardGraph(&state.info, recording, inputs);
+ runtime.info.fwd_graph = state.info.fwd_graph;
+ }
+ // build the indexed graph
+ nnvm::Graph& g = runtime.info.fwd_graph;
+ const auto& idx = g.indexed_graph();
+ const size_t num_inputs = idx.input_nodes().size();
+ const size_t num_entries = idx.num_node_entries();
+ std::vector<uint32_t> ref_count = g.GetAttr<std::vector<uint32_t> >(
+ recording ? "full_ref_count" : "forward_ref_count");
+ // construct `arrays`
+ runtime.buff.resize(num_entries);
+ std::vector<NDArray*> arrays;
+ arrays.reserve(num_entries);
+ for (auto& item : runtime.buff) {
+ arrays.push_back(&item);
+ }
Review comment:
i wonder if we should buffer arrays from the previous run?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
