mdespriee commented on issue #13039: [MXNET-918] Random module
URL: https://github.com/apache/incubator-mxnet/pull/13039#issuecomment-446655414
 
 
   @lanking520 I reviewed my `SymbolOrScalar` and `NDarrayOrScalar`, it's now a 
cleaner implem of typeclass pattern, it's more robust and not failing on edge 
cases.
   We still have an issue with `randint` expecting `Any` instead of proper 
types, but it may be addressed in a separate PR. What do you think ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to