larroy commented on a change in pull request #13535: [MXNET-244] Work around likely compiler bug on nested inlines and temporary acces… URL: https://github.com/apache/incubator-mxnet/pull/13535#discussion_r241585872
########## File path: src/operator/c_lapack_api.cc ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include "c_lapack_api.h" + +#if (MSHADOW_USE_MKL && MXNET_USE_LAPACK) Review comment: My point is that it's matching the define flow from the header file. But since it's causing confusion and I think your analysis is right, I can change it to read ``` #if MXNET_USE_LAPACK .... #endif ``` From your commend I understand that this would be your preference, am I correct? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
