cjolivier01 commented on a change in pull request #13472: [WIP][Don't merge]
Comment out dmlc::SetEnv in pthread_atfork #13438
URL: https://github.com/apache/incubator-mxnet/pull/13472#discussion_r242262709
##########
File path: src/initialize.cc
##########
@@ -57,9 +57,10 @@ class LibraryInitializer {
Engine::Get()->Start();
},
[]() {
+ // #13438
// Make children single threaded since they are typically workers
- dmlc::SetEnv("MXNET_CPU_WORKER_NTHREADS", 1);
- dmlc::SetEnv("OMP_NUM_THREADS", 1);
+ // dmlc::SetEnv("MXNET_CPU_WORKER_NTHREADS", 1);
+ // dmlc::SetEnv("OMP_NUM_THREADS", 1);
Review comment:
setting to 1 effectively disabled OMP (assuming OMP looks at the environment
variable after startup). What happens if the forked process tries to use OMP?
There should be a test for this because I know libgomp doesn't play well with
forking sometimes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
