gigasquid commented on a change in pull request #13626: Re-organize Scala maven
build
URL: https://github.com/apache/incubator-mxnet/pull/13626#discussion_r242324194
##########
File path: scala-package/core/pom.xml
##########
@@ -5,55 +5,71 @@
<modelVersion>4.0.0</modelVersion>
<parent>
<groupId>org.apache.mxnet</groupId>
- <artifactId>mxnet-parent_2.11</artifactId>
+ <artifactId>mxnet-parent</artifactId>
<version>1.5.0-SNAPSHOT</version>
<relativePath>../pom.xml</relativePath>
</parent>
- <properties>
- <skipTests>true</skipTests>
- <MXNET_DIR>${project.parent.basedir}/..</MXNET_DIR>
- </properties>
-
- <artifactId>mxnet-core_2.11</artifactId>
+ <artifactId>mxnet-core</artifactId>
<name>MXNet Scala Package - Core</name>
- <profiles>
- <profile>
- <id>unittest</id>
- <properties>
- <skipTests>false</skipTests>
- </properties>
- </profile>
- <profile>
- <id>osx-x86_64-cpu</id>
- <properties>
- <platform>osx-x86_64-cpu</platform>
- </properties>
- </profile>
- <profile>
- <id>linux-x86_64-cpu</id>
- <properties>
- <platform>linux-x86_64-cpu</platform>
- </properties>
- </profile>
- <profile>
- <id>linux-x86_64-gpu</id>
- <properties>
- <platform>linux-x86_64-gpu</platform>
- </properties>
- </profile>
- </profiles>
-
<build>
<plugins>
<plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-deploy-plugin</artifactId>
- <configuration>
- <skip>true</skip>
- </configuration>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>native-maven-plugin</artifactId>
+ <extensions>true</extensions>
+ <executions>
+ <execution>
+ <id>javah</id>
+ <phase>verify</phase>
+ <configuration>
+ <javahProvider>default</javahProvider>
+
<javahOutputDirectory>${project.build.directory}/custom-javah</javahOutputDirectory>
+ <workingDirectory>${basedir}</workingDirectory>
+
<javahOutputFileName>org_apache_mxnet_native_c_api.h</javahOutputFileName>
+ <javahClassNames>
+ <javahClassName>org.apache.mxnet.LibInfo</javahClassName>
+ </javahClassNames>
+ </configuration>
+ <goals>
+ <goal>javah</goal>
+ </goals>
+ </execution>
+ </executions>
</plugin>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
+ <version>1.6.0</version>
+ <executions>
+ <execution>
+ <id>verify-javah</id>
+ <phase>verify</phase>
+ <goals>
+ <goal>exec</goal>
+ </goals>
+ <configuration>
+ <successCodes>0</successCodes>
Review comment:
Removing this successCodes line enables my local computer to do `mvn
install`. I researched here
https://www.mojohaus.org/exec-maven-plugin/exec-mojo.html#successCodes and I
don't think it is needed in this case `Exit codes to be resolved as successful
execution for non-compliant applications (applications not returning 0 for
success).`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
