solin319 opened a new pull request #13683: fix bug in nag optimizer URL: https://github.com/apache/incubator-mxnet/pull/13683 ``` grad += wd * weight mom[:] += grad grad[:] += self.momentum * mom weight[:] += -lr * grad ``` This will minus wd*weight twice, but in formula ``` state = momentum * state + grad + wd * weight weight = weight - (lr * (grad + momentum * state)) ```` only minus once.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
