anirudh2290 commented on issue #12440: Add stable nrm2 for L2 normalization URL: https://github.com/apache/incubator-mxnet/pull/12440#issuecomment-448793556 There are pros and cons to both approaches. If @TccccD has to implement with Kernel::Launch approach he has to rely on mshadow reduce_with_axis and that is not very performant compared to the `ReduceAxesComputeImpl`. There is also another advantage that it moves the computation of L2 norm to a single location for both L2 Normalization op and LPNorm Operator and is more maintainable. As the goal of the PR is to improve stability of L2 norm operator it should be fine.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
