jiajinyu commented on issue #12958: Improve dot(csr, rsp) on CPU by 10x URL: https://github.com/apache/incubator-mxnet/pull/12958#issuecomment-448821236 > @jiajinyu You said you did benchmarks for 0.01 density of csr. I did NOT say that. Where did you see that? At this stage, I am not so keen to push this PR into mainline. I think for switch case like "density < x, do this; otherwise do that", the evaluation for a widely used framework like MXNet should be done extensively on various machines and scales. And this should not done by me. The solution in this PR make senses for large scale problem where sparsity is very strong. Actually we also have similar changes for other kernels. But I guess **this may not be the interest of MXNet**.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
