ZhennanQin opened a new pull request #13697: [MKLDNN] Enable signed int8 
support for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697
 
 
   ## Description ##
   Major changes:
   * Integrate mkldnn signed int8 convolution.
   * Introduce new quantization flow out_type `auto`, which determines the 
out_type according to calibration information. If negative value is detected 
from calibration min, out_type will be int8, otherwise, out_type will be uint8.
   * Introduce new operator quantize_v2, which only has 1 input data and will 
self-calculate min/max in runtime or use calibration information set by 
parameters. It also used to implement out_type `auto`.
   * Add new parameter `monitor_all` for monitor module to allow monitoring 
both input & output of operators. This is used for collecting calibration 
information of in_data to support quantize first layer of graph.
   
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to 
the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) 
created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding 
a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing 
distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a 
new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments 
are documented. 
   - For new examples, README.md is added to explain the what the example does, 
the source of the dataset, expected performance on test set and reference to 
the original paper if applicable
   - Check the API doc at 
http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to