sandeep-krishnamurthy commented on a change in pull request #13604: [WIP] onnx
broadcast ops fixes
URL: https://github.com/apache/incubator-mxnet/pull/13604#discussion_r244505599
##########
File path: python/mxnet/contrib/onnx/onnx2mx/_op_translations.py
##########
@@ -42,42 +42,62 @@ def random_normal(attrs, inputs, proto_obj):
def add(attrs, inputs, proto_obj):
"""Adding two tensors"""
new_attr = {}
+ op_names = ['batchnorm, convolution, deconvolution']
if 'broadcast' in attrs and attrs['broadcast'] == 1:
broadcast_axis = attrs['axis']
- op_value = translation_utils._fix_broadcast('broadcast_add', inputs,
- broadcast_axis, proto_obj)
- return op_value, new_attr, inputs
+ for op_name in op_names:
+ if inputs[0].name.startswith(op_name):
+ op_value = translation_utils._fix_broadcast('broadcast_add',
inputs,
+ broadcast_axis,
proto_obj)
+ return op_value, new_attr, inputs
+ else:
+ return 'broadcast_add', attrs, inputs
return 'broadcast_add', new_attr, inputs
def subtract(attrs, inputs, proto_obj):
"""Subtracting two tensors"""
new_attr = {}
+ op_names = ['batchnorm, convolution, deconvolution']
if 'broadcast' in attrs and attrs['broadcast'] == 1:
broadcast_axis = attrs['axis']
- op_value = translation_utils._fix_broadcast('broadcast_sub', inputs,
- broadcast_axis, proto_obj)
- return op_value, new_attr, inputs
+ for op_name in op_names:
+ if inputs[0].name.startswith(op_name):
+ op_value = translation_utils._fix_broadcast('broadcast_sub',
inputs,
+ broadcast_axis,
proto_obj)
+ return op_value, new_attr, inputs
+ else:
+ return 'broadcast_sub', attrs, inputs
return 'broadcast_sub', new_attr, inputs
def multiply(attrs, inputs, proto_obj):
"""Multiply two tensors"""
new_attr = {}
+ op_names = ['batchnorm, convolution, deconvolution']
Review comment:
This is repeated across. Can we simplify?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
