yifeim commented on issue #13244: hybridize rnn and add model graph URL: https://github.com/apache/incubator-mxnet/pull/13244#issuecomment-450515169 Can you make the changes? Thanks! On Sat, Dec 29, 2018 at 11:35 AM Yifei Ma <[email protected]> wrote: > Ok I agree. > > On Sat, Dec 29, 2018 at 11:25 AM Sandeep Krishnamurthy < > [email protected]> wrote: > >> >> 1. As noted in both README and help strings, hybridizing an RNN is >> not supported in mxnet<=1.2. 2. Export is the most obvious way for me to >> dump a network, unless you recommend a different approach that I am not >> aware of? >> … <#m_2218069160341530556_m_-5660027600346315218_> >> On Sat, Dec 29, 2018 at 10:56 AM Sandeep Krishnamurthy < ***@***.***> >> wrote: ***@.* commented on this pull request. Thanks for your >> contributions. 2 questions. 1. Why should Hybridize even be an option? Why >> can't we just have it as default? 2. export only is confusing or >> mis-leading. export is referred to a model (network + params) not just >> network. And, why is this option required? — You are receiving this because >> you were mentioned. Reply to this email directly, view it on GitHub <#13244 >> (review) >> <https://github.com/apache/incubator-mxnet/pull/13244#pullrequestreview-188419006>>, >> or mute the thread >> https://github.com/notifications/unsubscribe-auth/AIiQ6h7cUg0YOocWN_KGkUfSHxXLuo1mks5u97rHgaJpZM4Ya48l >> . >> >> >> 1. Yes, that makes sense. Thanks. >> 2. Export is fine. What I meant is 'export_only' does not convey that >> only network is exported. >> >> — >> You are receiving this because you were mentioned. >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/incubator-mxnet/pull/13244#issuecomment-450514393>, >> or mute the thread >> <https://github.com/notifications/unsubscribe-auth/AIiQ6gakEaMe6qR1giiiMTDi0ZVwA_qXks5u98GOgaJpZM4Ya48l> >> . >> >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
