KellenSunderland commented on a change in pull request #13697: [MKLDNN] Enable
signed int8 support for convolution.
URL: https://github.com/apache/incubator-mxnet/pull/13697#discussion_r244646779
##########
File path: include/mxnet/c_api.h
##########
@@ -1833,10 +1832,12 @@ MXNET_DLL int
MXExecutorGetOptimizedSymbol(ExecutorHandle handle,
/*!
* \brief set a call back to notify the completion of operation
+ * \param monitor_all If true, monitor both input and output, otherwise
monitor output only.
*/
MXNET_DLL int MXExecutorSetMonitorCallback(ExecutorHandle handle,
ExecutorMonitorCallback callback,
- void* callback_handle);
+ void* callback_handle,
+ bool monitor_all);
Review comment:
I think it might be useful for people directly using the c_api to have a
default value here. Generally as I mentioned above I believe MXNet only cares
about user APIs. However given this API has been around for a long time and
users often use the c_api I'd rather be safe than sorry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
