anirudhacharya commented on a change in pull request #13346: Aggregate SGD
URL: https://github.com/apache/incubator-mxnet/pull/13346#discussion_r245414855
##########
File path: python/mxnet/optimizer/optimizer.py
##########
@@ -502,6 +545,7 @@ def __init__(self, momentum=0.0, lazy_update=True,
**kwargs):
super(SGD, self).__init__(**kwargs)
self.momentum = momentum
self.lazy_update = lazy_update
+ self.aggregate_num = int(os.getenv('MXNET_OPTIMIZER_AGGREGATION_SIZE',
"4"))
Review comment:
in line 510 can you add a section on aggregate updates and in line 524 can
also point to these two methods - `multi_sgd_mom_update` and
`multi_mp_sgd_update` as optimizer update rules.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
