ptrendx commented on a change in pull request #13346: Aggregate SGD
URL: https://github.com/apache/incubator-mxnet/pull/13346#discussion_r245424783
##########
File path: python/mxnet/optimizer/optimizer.py
##########
@@ -502,6 +545,7 @@ def __init__(self, momentum=0.0, lazy_update=True,
**kwargs):
super(SGD, self).__init__(**kwargs)
self.momentum = momentum
self.lazy_update = lazy_update
+ self.aggregate_num = int(os.getenv('MXNET_OPTIMIZER_AGGREGATION_SIZE',
"4"))
Review comment:
I wrote the section on aggregate updates, but I'm not sure about pointing to
the new methods in line 524 - they use the same algorithm as the `sgd_update`
and `sgd_mom_update` functions so pointing to those functions for details of
the algorithm seems sufficient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
