huangzhiyuan commented on a change in pull request #13730: Add mkldnn OP for
slice
URL: https://github.com/apache/incubator-mxnet/pull/13730#discussion_r245496799
##########
File path: src/operator/tensor/matrix_op-inl.h
##########
@@ -432,7 +419,20 @@ inline bool SliceForwardInferStorageType(const
nnvm::NodeAttrs& attrs,
&& (!param.step[0].has_value() || param.step[0].value() == 1)) {
trivial_step = true;
}
- if (!dispatched && in_stype == kDefaultStorage) {
+ if (!dispatched && in_stype == kDefaultStorage && trivial_step) {
Review comment:
trivial_step is a flag variable, if trivial_step = false, it will call
fallback function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
