piyushghai commented on a change in pull request #13678: [MXNET-1260] Float64 
DType computation support in Scala/Java
URL: https://github.com/apache/incubator-mxnet/pull/13678#discussion_r246896108
 
 

 ##########
 File path: scala-package/core/src/test/scala/org/apache/mxnet/IOSuite.scala
 ##########
 @@ -303,5 +303,32 @@ class IOSuite extends FunSuite with BeforeAndAfterAll {
     assert(dataDesc(0).layout == Layout.NTC)
     assert(labelDesc(0).dtype == DType.Int32)
     assert(labelDesc(0).layout == Layout.NT)
+
+
+    // Test with passing Float64 hardcoded as Dtype of data
+    val dataIter4 = new NDArrayIter(
+      IO.initDataDesc(data, false, "data", DType.Float64, Layout.NTC),
+      IO.initDataDesc(label, false, "label", DType.Int32, Layout.NT),
 
 Review comment:
   The default DType in DataDesc is Float32. In this test, I'm trying to show 
here that not just Float64, but any other DType would also work with Data 
Descriptors :) 
   
   And yes, for labels, people don't require higher precision datatypes. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to