aaronmarkham commented on a change in pull request #12845: Julia v0.7/1.0
support and drop v0.6 support
URL: https://github.com/apache/incubator-mxnet/pull/12845#discussion_r246974766
##########
File path: ci/docker/runtime_functions.sh
##########
@@ -1224,24 +1234,18 @@ deploy_docs() {
deploy_jl_docs() {
set -ex
- export PATH="/work/julia/bin:$PATH"
+ export PATH="/work/julia10/bin:$PATH"
export MXNET_HOME='/work/mxnet'
- export JULIA_PKGDIR='/work/julia-pkg'
- export DEPDIR=`julia -e 'print(Pkg.dir())'`
+ export JULIA_DEPOT_PATH='/work/julia-depot'
+ export DEVDIR="$JULIA_DEPOT_PATH/dev"
- julia -e 'versioninfo()'
- julia -e 'Pkg.init()'
- ln -sf ${MXNET_HOME}/julia ${DEPDIR}/MXNet
- julia -e 'Pkg.resolve()'
+ julia -e 'using InteractiveUtils; versioninfo()'
+ mkdir -p $DEVDIR
# FIXME
export LD_PRELOAD='/usr/lib/x86_64-linux-gnu/libjemalloc.so'
- # use the prebuilt binary from $MXNET_HOME/lib
- julia -e 'Pkg.build("MXNet")'
- # build docs
- julia -e 'Pkg.add("Documenter")'
- julia -e 'cd(Pkg.dir("MXNet")); include(joinpath("docs", "make.jl"))'
+ make -C docs
Review comment:
But is that somehow required to generate the Julia docs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
