kedarbellare commented on a change in pull request #13864: [Clojure] package infer tweaks URL: https://github.com/apache/incubator-mxnet/pull/13864#discussion_r247322347
########## File path: contrib/clojure-package/examples/infer/objectdetector/src/infer/objectdetector_example.clj ########## @@ -54,23 +54,16 @@ "Print image detector predictions for the given input file" [predictions width height] (println (apply str (repeat 80 "="))) - (doseq [[label prob-and-bounds] predictions] - (println (format - "Class: %s Prob=%.5f Coords=(%.3f, %.3f, %.3f, %.3f)" - label - (aget prob-and-bounds 0) - (* (aget prob-and-bounds 1) width) - (* (aget prob-and-bounds 2) height) - (* (aget prob-and-bounds 3) width) - (* (aget prob-and-bounds 4) height)))) + (doseq [p predictions] + (println p)) Review comment: minor: one thing this does change is that the bounds (e.g. `x-min`, `y-min`) are not scaled by the width and height of the image. is that fine? maybe this should be added in the docstring of the detection method? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
