eric-haibin-lin commented on a change in pull request #13346: Aggregate SGD
URL: https://github.com/apache/incubator-mxnet/pull/13346#discussion_r247736512
##########
File path: python/mxnet/gluon/trainer.py
##########
@@ -393,6 +393,8 @@ def update(self, batch_size, ignore_stale_grad=False):
self._update(ignore_stale_grad)
def _update(self, ignore_stale_grad=False):
Review comment:
Do you mind adding a note in Trainer constructor that:
"If update_on_kvstore argument is provided, environment variable
MXNET_UPDATE_ON_KVSTORE will be ignored"?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
