marcoabreu commented on a change in pull request #13884: [CI][URGENT] Fixes for
docker cache generation
URL: https://github.com/apache/incubator-mxnet/pull/13884#discussion_r247983625
##########
File path: ci/docker_cache.py
##########
@@ -240,16 +234,36 @@ def script_name() -> str:
logging.basicConfig(format='{}: %(asctime)-15s
%(message)s'.format(script_name()))
parser = argparse.ArgumentParser(description="Utility for preserving and
loading Docker cache", epilog="")
+
parser.add_argument("--docker-registry",
help="Docker hub registry name",
- type=str,
- required=True)
+ default="mxnetci",
+ type=str)
+
+ parser.add_argument("--docker-secret-name",
+ help="secrets manager name",
+ default="prod/DockerCache/DockerHubCredentials",
Review comment:
The environment variables were chosen because they are environment specific
variables (think about prod and test config).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
