larroy commented on a change in pull request #13311: [MXNET-703] Minor refactor
of TensorRT code
URL: https://github.com/apache/incubator-mxnet/pull/13311#discussion_r248047439
##########
File path: src/executor/trt_graph_executor.cc
##########
@@ -434,7 +435,7 @@ Executor *TrtGraphExecutor::TensorRTBind(nnvm::Symbol
symbol,
std::unordered_map<std::string,
NDArray> *shared_buffer,
Executor *shared_exec) {
auto exec = new exec::TrtGraphExecutor();
- exec->Init(symbol, default_ctx, group2ctx,
+ exec->Init(std::move(symbol), default_ctx, group2ctx,
Review comment:
Well the question if the move is doing anything, because I don't know if
there's an Init signature accepting an rvalue reference to a symbol, that was
the original question.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
