KellenSunderland commented on a change in pull request #13311: [MXNET-703] 
Minor refactor of TensorRT code
URL: https://github.com/apache/incubator-mxnet/pull/13311#discussion_r248101123
 
 

 ##########
 File path: src/executor/trt_graph_executor.cc
 ##########
 @@ -434,7 +435,7 @@ Executor *TrtGraphExecutor::TensorRTBind(nnvm::Symbol 
symbol,
                                          std::unordered_map<std::string, 
NDArray> *shared_buffer,
                                          Executor *shared_exec) {
   auto exec = new exec::TrtGraphExecutor();
-  exec->Init(symbol, default_ctx, group2ctx,
+  exec->Init(std::move(symbol), default_ctx, group2ctx,
 
 Review comment:
   Yeah I was also curious about this.  The example shows a similar pattern and 
it does save a copy.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to