larroy commented on a change in pull request #13472: [WIP][Don't merge] Comment 
out dmlc::SetEnv in pthread_atfork #13438
URL: https://github.com/apache/incubator-mxnet/pull/13472#discussion_r248286329
 
 

 ##########
 File path: src/initialize.cc
 ##########
 @@ -57,9 +57,10 @@ class LibraryInitializer {
         Engine::Get()->Start();
       },
       []() {
+        // #13438
         // Make children single threaded since they are typically workers
-        dmlc::SetEnv("MXNET_CPU_WORKER_NTHREADS", 1);
-        dmlc::SetEnv("OMP_NUM_THREADS", 1);
+        // dmlc::SetEnv("MXNET_CPU_WORKER_NTHREADS", 1);
+        // dmlc::SetEnv("OMP_NUM_THREADS", 1);
 
 Review comment:
   Thanks for your review Chris. Can you elaborate and provide more detail on 
what do you suggest to do? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to