stu1130 commented on a change in pull request #13907: Fixes downloading of data
in cpp-package/example/get_data.sh
URL: https://github.com/apache/incubator-mxnet/pull/13907#discussion_r248416291
##########
File path: cpp-package/example/get_data.sh
##########
@@ -14,28 +15,29 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+set -euo pipefail
+
unameOut="$(uname -s)"
case "${unameOut}" in
- Linux*) CMD='wget';;
- Darwin*) CMD='curl -o';;
- CYGWIN*) CMD='wget';;
- MINGW*) CMD='wget';;
+ Linux*) CMD='wget -q';;
Review comment:
how about adding some log to tell users that it is downloading something
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
