yuxihu commented on a change in pull request #13922: Support populating errors
back to MXNet engine in callback
URL: https://github.com/apache/incubator-mxnet/pull/13922#discussion_r248872200
##########
File path: include/mxnet/engine.h
##########
@@ -74,15 +74,15 @@ class CallbackOnComplete {
public:
// use implicit copy and assign
/*! \brief involve the callback */
- inline void operator()() const {
- (*callback_)(engine_, param_);
+ inline void operator()(const char* error_msg = nullptr) const {
Review comment:
The error code is not universally defined across different libraries. In the
Horovod case, the error types are mostly Horovod specific. We convert all those
to dmlc::Error which MXNet can catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
