apeforest commented on a change in pull request #13922: Support populating
errors back to MXNet engine in callback
URL: https://github.com/apache/incubator-mxnet/pull/13922#discussion_r248875587
##########
File path: include/mxnet/engine.h
##########
@@ -74,15 +74,15 @@ class CallbackOnComplete {
public:
// use implicit copy and assign
/*! \brief involve the callback */
- inline void operator()() const {
- (*callback_)(engine_, param_);
+ inline void operator()(const char* error_msg = nullptr) const {
Review comment:
Can we define an error data structure and export it? So all libraries that
consume libmxnet will use this error data structure to pass data back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
