zheng-da commented on a change in pull request #13903: mkldnn s8 conv API
change for master
URL: https://github.com/apache/incubator-mxnet/pull/13903#discussion_r249428960
##########
File path: src/ndarray/ndarray.cc
##########
@@ -168,16 +168,28 @@ nnvm::Symbol NDArray::get_autograd_symbol() const {
#if MXNET_USE_MKLDNN == 1
-NDArray::NDArray(const mkldnn::memory *mkldnn_mem, bool static_data)
Review comment:
it seems the old impl is incorrect. what if `static_data=false`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
