lebeg commented on a change in pull request #13957: Always go through cmake/ChooseBlas.cmake, now we only execute this lo… URL: https://github.com/apache/incubator-mxnet/pull/13957#discussion_r249874609
########## File path: CMakeLists.txt ########## @@ -294,8 +294,8 @@ else() add_definitions(-DMXNET_USE_NCCL=0) endif() +include(cmake/ChooseBlas.cmake) Review comment: Lots of stuff from here will be overwritten (and misconfigured) due to the `else()` branch, when the [mshadow scripts](https://github.com/dmlc/mshadow/blob/master/cmake/mshadow.cmake) kick in. On the other hand if it passes CI, then why not? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
