larroy commented on a change in pull request #13964: Addresses comments in runtime feature discovery URL: https://github.com/apache/incubator-mxnet/pull/13964#discussion_r250154027
########## File path: include/mxnet/c_api.h ########## @@ -208,6 +208,24 @@ MXNET_DLL const char *MXGetLastError(); //------------------------------------- // Part 0: Global State setups //------------------------------------- + +/*! + * \brief Check if a feature is enabled in the runtime + * \param feature to check mxruntime.h + * \param out set to true if the feature is enabled, false otherwise + * \return 0 when success, -1 when failure happens. + */ +MXNET_DLL int MXRuntimeHasFeature(const mx_uint feature, bool *out); Review comment: See comment below, we have to decide either two functions returning strings with values (available and enabled) and another solution having one function returning strings (optionally values) and another function to check if the flag is present. For me the later is perfectly fine and more efficient with less allocation. Why do you think the former is superior? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
