lanking520 commented on a change in pull request #13979: [MXNET-1232] fix demo and add Eclipse support URL: https://github.com/apache/incubator-mxnet/pull/13979#discussion_r250821238
########## File path: scala-package/mxnet-demo/java-demo/pom.xml ########## @@ -21,7 +28,30 @@ <mxnet.version>[1.5.0-SNAPSHOT, )</mxnet.version> </properties> </profile> - </profiles> + <profile> + <id>osx-x86_64</id> + <activation> + <os> + <family>mac</family> + </os> + </activation> + <properties> + <mxnet.profile>osx-x86_64-cpu</mxnet.profile> + </properties> + </profile> + <profile> + <id>linux-x86_64</id> + <activation> + <os> + <family>unix</family> + <name>Linux</name> + </os> + </activation> + <properties> + <mxnet.profile>linux-x86_64-cpu</mxnet.profile> Review comment: In order to simplify the process, I decided to get rid of the makefile entirely. To address your concern, I add a noteline in the README to inform then using GPU to run ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services