szha commented on issue #13956: C API should *never* call abort() URL: https://github.com/apache/incubator-mxnet/issues/13956#issuecomment-457893146 By default, those checks should be throwing instead of calling `abort()`. https://github.com/dmlc/dmlc-core/blob/master/include/dmlc/logging.h#L25-L26 It will abort only when `defined(_LIBCPP_SGX_NO_IOSTREAMS)` https://github.com/dmlc/dmlc-core/blob/master/include/dmlc/logging.h#L351 or when `DMLC_LOG_FATAL_THROW` is explicitly set to 0. https://github.com/dmlc/dmlc-core/blob/master/include/dmlc/logging.h#L362 Since the build logic of mxnet itself uses the default setting, I'd like to see how and in what scenarios you trigger either the first or the second case, after which we can try to come up with the fix necessary.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
