lanking520 commented on a change in pull request #13816: Add default
parameters for Scala NDArray.arange
URL: https://github.com/apache/incubator-mxnet/pull/13816#discussion_r251556669
##########
File path: scala-package/core/src/main/scala/org/apache/mxnet/NDArray.scala
##########
@@ -405,15 +405,13 @@ object NDArray extends NDArrayBase {
* @param stop End of interval.
* @param step Spacing between values. The default step size is 1.
* @param repeat Number of times to repeat each element. The default repeat
count is 1.
- * @param infer_range
- * When set to True, infer the stop position from the start, step,
- * repeat, and output tensor size.
* @param ctx Device context. Default context is the current default context.
* @param dType The data type of the `NDArray`. The default datatype is
`DType.Float32`.
* @return NDArray of evenly spaced values in the specified range.
*/
- def arange(start: Float, stop: Option[Float], step: Float,
- repeat: Int, ctx: Context, dType: DType): NDArray = {
+ def arange(start: Float, stop: Option[Float] = None, step: Float = 1.0f,
Review comment:
Unless you are certain that this param is not going to be used, please place
it at the end of the param list and rename it as inferRange follows Java camel
case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
