vandanavk commented on a change in pull request #14066: Add dtype visualization
to plot_network
URL: https://github.com/apache/incubator-mxnet/pull/14066#discussion_r253697057
##########
File path: python/mxnet/visualization.py
##########
@@ -274,11 +278,19 @@ def plot_network(symbol, title="plot",
save_format='pdf', shape=None, node_attrs
draw_shape = False
if shape is not None:
draw_shape = True
- interals = symbol.get_internals()
- _, out_shapes, _ = interals.infer_shape(**shape)
+ internals = symbol.get_internals()
Review comment:
can we move get_internals to before if shape ? its called again inside if
dtype
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
