edisongustavo edited a comment on issue #13400: [MXNET-1229] use OpenBLAS, 
lapack & OpenCV from conan
URL: https://github.com/apache/incubator-mxnet/pull/13400#issuecomment-461046247
 
 
   If we add Conan support like this won't it require a connection to the conan 
artifacts repository while building?
   
   My main issue with Conan is that it "spreads over" your Cmake files (like it 
did in this case). It looks like it is an "all or nothing" solution. What would 
happen if I **do want** to compile against the dependencies of my operating 
system? Could I do that?
   
   # Alternative
   
   An alternative to provide all dependencies is to use conda (disclaimer: I'm 
a big conda fan). If we have a conda-environment file declaring all the 
dependencies, then the steps would be:
   
   ```
   $ cd <mxnet-source-directory>
   $ conda env create -f environment.yml -n mxnet-compilation-dependencies
   $ conda activate mxnet-compilation-dependencies
   $ mkdir build
   $ cmake -DCMAKE_PREFIX_PATH=$CONDA_PREFIX ..
   $ make
   ```
   
   This is something I want to work on the next few weeks, so it is on my 
roadmap.
   
   # Cool, but I want Conan!
   
   I agree that adding Conan support is important, but let's think about it 
more thoroughly and not let it "spread over" the cmake files.
   
   Let's think more deeply in how to add Conan support into Mxnet.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to