marcoabreu commented on issue #13884: [CI][URGENT] Fixes for docker cache generation URL: https://github.com/apache/incubator-mxnet/pull/13884#issuecomment-462732821 While I understand that environment variables will greatly speed up the duration of an iteration, I don't feel comfortable adding a hack to our configuration system. Right now, everything is defined as configuration in code that's entirely versioned. Introducing these varibales opens the possibilities to modify configuration without audit trail or approval. Considering that anybody can just change these values in a production system without notice or review, it doesn't seem like best practice to me to introduce this feature. If someone wants to iterate, I'd suggest to create a job in dev, create a branch and change the configuration values inside the code. But environment variables will have an impact on ALL jobs instead of being local to a specific branch or job.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
