marcoabreu commented on issue #13884: [CI] Refactor for docker cache generation script URL: https://github.com/apache/incubator-mxnet/pull/13884#issuecomment-462790396 The only exception where environment variables were chosen was here: https://github.com/apache/incubator-mxnet/pull/13884/files#diff-76bb673252e787d0be4340b502e89719L193 This was necessary because these are deployment/environment-specific variables. These variables on the other hand are being removed by you here: https://github.com/apache/incubator-mxnet/pull/13884/files#diff-76bb673252e787d0be4340b502e89719R245 Thus, this change entirely inverts the whole existing design strategy for the configuration.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
