szha commented on a change in pull request #14066: Add dtype visualization to
plot_network
URL: https://github.com/apache/incubator-mxnet/pull/14066#discussion_r256197929
##########
File path: python/mxnet/visualization.py
##########
@@ -274,11 +278,19 @@ def plot_network(symbol, title="plot",
save_format='pdf', shape=None, node_attrs
draw_shape = False
if shape is not None:
draw_shape = True
- interals = symbol.get_internals()
- _, out_shapes, _ = interals.infer_shape(**shape)
+ internals = symbol.get_internals()
+ _, out_shapes, _ = internals.infer_shape(**shape)
if out_shapes is None:
raise ValueError("Input shape is incomplete")
- shape_dict = dict(zip(interals.list_outputs(), out_shapes))
+ shape_dict = dict(zip(internals.list_outputs(), out_shapes))
+ draw_type = False
+ if dtype is not None:
Review comment:
nit: this seems slightly more readable.
```python
draw_type = dtype is not None
if draw_type:
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
