ChaiBapchya commented on a change in pull request #14144: Fixes installation 
nightly test
URL: https://github.com/apache/incubator-mxnet/pull/14144#discussion_r256685757
 
 

 ##########
 File path: tests/jenkins/run_test_installation_docs.sh
 ##########
 @@ -250,6 +250,20 @@ function set_instruction_set() {
         ${sorted_indexes[$end_buildfromsource_command_index]})
 }
 
+# given a build commands string, filter any build commands that ought not be 
executed
+# during the test. An example would be git clone'ing the mxnet repository. You 
want to 
 
 Review comment:
   Also would like to rephrase the sentence "You want to run the tests against 
the current commit being tested in Jenkins" - I am unable to understand how 
does in this example "filter_build_command" play a role?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to