edisongustavo commented on a change in pull request #14028: Cmake blas
URL: https://github.com/apache/incubator-mxnet/pull/14028#discussion_r257642857
##########
File path: ci/docker/Dockerfile.build.android_armv8
##########
@@ -73,7 +73,7 @@ ENV CXX=${CROSS_ROOT}/bin/${CROSS_TRIPLE}-clang++
# Build ARM dependencies.
COPY install/android_arm64_openblas.sh /work/
RUN /work/android_arm64_openblas.sh
-ENV CPLUS_INCLUDE_PATH /work/deps/OpenBLAS
+ENV OpenBLAS_HOME=/work/deps/OpenBLAS
Review comment:
> Did you figure out if this affects anything downstream?
What do you mean by that? If any other image is using this docker image? I
didn't check that, but it shouldn't affect any downstreams, unless they're
depending on this, which would be depending on an undocumented hack.
> and is it worth moving this change to a different PR for PR atomicity, etc.
The problem is that this change is **required** for this PR to be merged.
Without this change it won't work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
