reminisce commented on a change in pull request #14409: [Numpy] Change semantics of ndim for operators in `src/operator/contrib` URL: https://github.com/apache/incubator-mxnet/pull/14409#discussion_r265670608
########## File path: src/operator/contrib/optimizer_op.cc ########## @@ -45,7 +45,7 @@ inline bool GroupAdagradShape(const nnvm::NodeAttrs &attrs, SHAPE_ASSIGN_CHECK(*in_attrs, 0, out_attrs->at(0)); SHAPE_ASSIGN_CHECK(*in_attrs, 1, out_attrs->at(0)); - return out_attrs->at(0).ndim() != 0U && out_attrs->at(0).Size() != 0U && + return !mxnet::op::shape_is_none(out_attrs->at(0)) && out_attrs->at(0).Size() != 0U && Review comment: Same as above. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
